-
Notifications
You must be signed in to change notification settings - Fork 813
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(histogram): fix maximum when only values < -1 are provided #3086
fix(histogram): fix maximum when only values < -1 are provided #3086
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3086 +/- ##
==========================================
- Coverage 93.08% 92.66% -0.42%
==========================================
Files 188 173 -15
Lines 6261 5523 -738
Branches 1323 1175 -148
==========================================
- Hits 5828 5118 -710
+ Misses 433 405 -28
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update. I think at one point the spec had positive only values so this is likely a remnant of that? Not sure. In any case it is a good change.
When I recently implemented this feature in #3032, I was not thinking of Histogram Aggregations in combination with |
Which problem is this PR solving?
HistogramAggregator
incorrectly assumes positive-only values, and therefore produces wrongmax
values on export when only negative values are provided (e.g. whenExplicitBucketHistogramAggregation
is used withUpDownCounter
viaView
configuration).This PR fixes this by replacing the default
max
with-Infinity
Fixes #3085
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: